This provides some improvements to the TAS Recorder interop:
Updated the API to reflect changes with how recording durations now works (doesn't really make a difference)
Removed the optional frames parameter from StartRecording. I don't see any good usage for this of a StartRecording/StopRecording pair.
Calculate the duration if there is no finishing StopRecording
Disallow Record TAS and StartRecording/StopRecording. Record TAS implies that the entire TAS will be recorded, but recording commands could mess with that. A StartRecording at the beginning achieves basically the same
Allow setting strings with Set commands. I know the solution definitly isn't optimal but mostly works: Set SomeMod.SomeSetting Hello, World! => Hello, World!, whileSet, SomeMod.SomeSetting, Hello, World!=>Hello World!`. I seems like properly supporting strings would require getting the exact separator somehow or a complete rework of the command system.
This provides some improvements to the TAS Recorder interop:
StartRecording
. I don't see any good usage for this of aStartRecording
/StopRecording
pair.StopRecording
Record TAS
andStartRecording
/StopRecording
.Record TAS
implies that the entire TAS will be recorded, but recording commands could mess with that. AStartRecording
at the beginning achieves basically the sameSet
commands. I know the solution definitly isn't optimal but mostly works:Set SomeMod.SomeSetting Hello, World!
=>Hello, World!, while
Set, SomeMod.SomeSetting, Hello, World!=>
Hello World!`. I seems like properly supporting strings would require getting the exact separator somehow or a complete rework of the command system.