EverestAPI / CelesteTAS-EverestInterop

Everest interop for DevilSquirrel's CelesteTAS
https://github.com/EuniverseCat/CelesteTAS
MIT License
67 stars 28 forks source link

Add RequireDependency Command #70

Open LozenChen opened 7 months ago

LozenChen commented 7 months ago

this command checks if the dependency is loaded. If not, the game will goto the mod options menu

LozenChen commented 7 months ago

it may happen that SPACE or Comma appears in mod name, so maybe we need to use some escape characters

psyGamer commented 7 months ago

String arguments in commands was implemented a bit hacky by me. Properly parsing the string by maybe requiring "" around it could make sense. Afaik no TAS should really depend on setting a string, so a breaking change should be fine.

psyGamer commented 3 weeks ago

Hmm yeah I kinda like this idea. But I think it should simply abort the TAS like Assert does. But it would be really cool to have an "Install Dependencies" like screen pop-up where you have the option to automatically install/enable the required mods. Additionally, this PR needs to be retargetet to the latest master. Note that I would recommend waiting a bit with doing since I'm still planning on refactoring some things related to commands. Will comment once I think it should be stable enough.