search

EverestAPI / CelesteTAS-EverestInterop

Everest interop for DevilSquirrel's CelesteTAS
https://github.com/EuniverseCat/CelesteTAS
MIT License
67 stars 28 forks source link

Free Camera Fix with "Upside Down" Extended Variant and Fix for hitbox overdraw in Lunar Pagoda #76

Open TyrannicalThesaurus opened 4 months ago

TyrannicalThesaurus commented 4 months ago

Free Camera with mouse and keyboard had unintuitive behavior with the "Upside Down" Extended Variant. When the camera flipped, the vertical movement did not also get flipped, which made the camera feel odd to move around as one axis was inverted and the other was not. I fixed this by checking if "Upside Down" is enabled, and then inverting the center camera movement if so.

Clip From before the change:

https://github.com/user-attachments/assets/004495a5-0c2c-442a-bd18-0cadf242c988

Clip from after the change:

https://github.com/user-attachments/assets/46b4e962-7333-4a59-a497-825b2d8ba545

TyrannicalThesaurus commented 4 months ago

The stopwatch entity in Lunar Pagoda works by turning the screen grayscale, and then redrawing on top of the screen. This had the unintended effect of drawing over CelesteTAS's Show Hitboxes feature. I fixed this by hooking into Spirialis Helper, and adding a check to remove the redrawing when show hitboxes is enabled.

Clip from before the fix:

https://github.com/user-attachments/assets/3db2ef65-ccc5-4325-a638-92436d0659b6

Clip from after the fix:

https://github.com/user-attachments/assets/72817eb6-137e-4461-ad04-f1a64c485d7b

psyGamer commented 3 weeks ago

This PR needs to be retargeted onto master. I think the only issue is me moving files around? Sorry about that. Also about the upside down from ext-vars, what do you think about disabling that with simplified graphics?

psyGamer commented 2 weeks ago

While this is now mergable, I would prefer if the fix for the stopwatch would be drawing the hitboxes after SpirialisHelper has redrawn it's entities, instead of just disabling that redrawing.