search

EverestAPI / CelesteTAS-EverestInterop

Everest interop for DevilSquirrel's CelesteTAS
https://github.com/EuniverseCat/CelesteTAS
MIT License
67 stars 28 forks source link

feat(Studio): choose line number padding based on visible rows #83

Open jakobhellermann opened 1 month ago

jakobhellermann commented 1 month ago

It works but I don't like the code.

  1. bottomRow is copied to 3 locations. It could be extracted to a function, but one location also wants visualBottomRow, topRow and visualTopRow.
  2. storing previousMaxDigits to prevent Recalc on every scroll event
  3. offscreenLinePadding. Where does the 3 come from? In the Searching... case it expands the padding on line 98, ingame at 97.

https://github.com/user-attachments/assets/a583e0ee-483a-45d4-892e-c06f256c9b4a