Replace DiscordRPC with GameSDK

coloursofnoise commented 3 years ago

The Everest DiscordRPC integration is broken on MacOS, and the DiscordRPC Library has been deprecated in favour of Discord's GameSDK.

endorpersand commented 2 years ago

I believe I have figured out why Everest's DiscordRPC integration is broken on macOS.

In the current Everest code, the platform is being checked like so:

if (!string.IsNullOrEmpty(CoreModule.Settings.DiscordLib))
    lib = CoreModule.Settings.DiscordLib;
else if (Environment.OSVersion.Platform == PlatformID.Win32NT)
    lib = "discord-rpc.dll";
else if (Environment.OSVersion.Platform == PlatformID.MacOSX) {
    lib = "libdiscord-rpc.dylib";
    // FIXME: macOS doesn't see libdiscord-rpc.dylib wherever Celeste.exe is.
} else if (Environment.OSVersion.Platform == PlatformID.Unix)
    lib = "libdiscord-rpc.so";

However, on macOS, Environment.OSVersion.Platform is Unix, not MacOSX. So, Everest tries to use libdiscord-rpc.so rather than libdiscord-rpc.dylib, causing rich presence to fail on macOS.

At the moment, a workaround for current macOS users is to open Saves > modsettings-Everest.celeste and replace the line DiscordLib: '' with DiscordLib: libdiscord-rpc.dylib.

A possible permanent solution would be to try libdiscord-rpc.so on Unix platforms and then try libdiscord-rpc.dylib if libdiscord-rpc.so fails.

KTibow commented 2 years ago

reposting this since someone from the discord recommended me to it would be nice if when you folks get around to replacing the discord rich presence component, you could also improve the design a bit, in a couple ways

remove the original rich presence (if possible); having 2 rich presences are bad
use the image; it makes things feel more aligned, gives an opportunity to add art, and lets you add another text field (see https://discord.com/developers/docs/rich-presence/best-practices#use-all-of-the-fields-where-applicable)
consider using words instead of emoji, it makes it more understandable
consider moving around things to match up with the field names; see the page i linked before, also this diagram