EvergineTeam / Vulkan.NET

This repository contains low-level bindings for Vulkan used in Evergine.
MIT License
197 stars 18 forks source link

Inconsistency with Vulkan API vkCmdSetFragmentShadingRateKHR #9

Open jayrulez opened 2 years ago

jayrulez commented 2 years ago

There seems to be an issue here:

https://github.com/EvergineTeam/Vulkan.NET/blob/2e1290c2c3f4e3cf81c5307bd0e84c3224b3b08e/VulkanGen/Evergine.Bindings.Vulkan/Generated/Commands.cs#L2423

The vulkan API is

// Provided by VK_KHR_fragment_shading_rate
void vkCmdSetFragmentShadingRateKHR(
    VkCommandBuffer                             commandBuffer,
    const VkExtent2D*                           pFragmentSize,
    const VkFragmentShadingRateCombinerOpKHR    combinerOps[2]);

taking two VkFragmentShadingRateCombinerOpKHR

jayrulez commented 2 years ago

I have a fix for this in my fork: https://github.com/jayrulez/Bulkan.Generator/commit/2dcdf05451f6aa4be91bfa2d310ad2e36776fc1f

Perhaps you want it to use it or fix it differently.

jcant0n commented 1 year ago

Hi,

I'm going to review this fix before make this changes.

Thank you for your help!