EveripediaNetwork / issues

Issues repo
9 stars 0 forks source link

Rounding/Decimals error in the locking section #858

Closed JustinCast closed 2 years ago

JustinCast commented 2 years ago

There seems to be a rounding error in the frontend. There are some transactions that fail when the increase_amount method is called.

  1. https://etherscan.io/tx/0xe02c0ace40720647214bb6f490466012460f2f55e1f3dd890a027d864421713c
  2. https://etherscan.io/tx/0x273f69cbdd15b8f96147b19a1935b179e2cc1ec639339289cef784133667c5f3

There are more...

We can use two also for now, but ideally, we should use bignumbers to avoid the bug

I think the error is happening when the user has iq with decimals and hit the MAX button

JustinCast commented 2 years ago

@Emmanueldmlr I changed to toFixed(3) and it worked, you can check further image

kesar commented 2 years ago

i think this still needs to get solved right @Emmanueldmlr ?

Emmanueldmlr commented 2 years ago

Oh...I thought @JustinCast already fixed it.