search

Everlag / preordain-backend

backend for preorda.in
Other
1 stars 0 forks source link

Separate code from data #5

Closed Everlag closed 8 years ago

Everlag commented 9 years ago

Right now, binaries are hard coded to specific file locations relative to their working directory. This poses all kinds of issues with sanely deploying new builds or new data.

Both long lived and utility programs should aim to have sane defaults for development with environment variables specifying production locations.

Aim to have production data locations, ie, a single AllSets-x.json rather than one per binary.

Everlag commented 9 years ago

ec007535071f1f2ec8fe145c67dc05f7e2e88653 and cce3fcd9e1f724d32d5bc8559682859b09ba47e7 solve this issue for the price api.

Everlag commented 9 years ago

248e1fc89979e38cb40beb5e1404616404e26a91 fixes priceWriter

cardData is the only section left. It's a massive one though.

Everlag commented 9 years ago

Ignoring user api for now, its not being actively used.

Everlag commented 8 years ago

67f839f5d6ca741c6e7a4f756053c1210eac3ec2 moves setlist fetching to a centralized, environment variable aware package.

f04803747dbebcba221c4a5134f22add669b37b3 removes similarity info from cardData. It's not actively being used so its unnecessary complexity in the refactor.

Everlag commented 8 years ago

4df8963220707d1c6e799ef6a42aec75f8218ca2 solves cardData for this issue.

This should close this issue; however, there have been many significant changes so more testing is needed before that happens.

Everlag commented 8 years ago

Everything has been tested and is in production. Nothing broke!