Everlag / preordain-backend

backend for preorda.in
Other
1 stars 0 forks source link

Normalize card names #8

Open Everlag opened 8 years ago

Everlag commented 8 years ago

Currently, cards which contain non-ascii characters, such as Séance or Æther Vial, possess inconsistent names across the static and dynamic endpoints.

Using Æther Vial as an example,

The fact that the price lookup completely fails for mtgprice in every case means that we cannot just tell the client to smooth our edge cases.

Everlag commented 8 years ago

Another facet of the Æther Vial problem is that a full set query for Modern Masters returns the card with the mtgprice 'AEther Vial' name rather than the official.

At which point do we normalize names? Intake in priceWriter or output in price api?