search

Everlag / preordain-client

The full client that sits at https://preorda.in
Other
1 stars 0 forks source link

Last gallery images oversized #15

Closed Everlag closed 8 years ago

Everlag commented 9 years ago

When a gallery does not perfectly sub-divide the available space with the images allocated for that progressive load, the last few images get bloated to cover the remainder of space.

The simple solution of setting a max-width does not work as the gallery contracts away from the right edge as a result. Setting specific css rules for the last 2/3/4 images is a dirty hack but might work.

Leaving it as is would work as it isn't particularly damning stylistically but does feel odd to find two massive images at the end of the gallery before the loading trigger.

Everlag commented 8 years ago

Perhaps setting regular polling on the last few gallery elements, if template binding allows, could allow us to check if they are in view and then load the next section in. This solves this issue while also providing a nicer scrolling experience.

How would this interact with the bottom stopper already present? Would this get it demoted to spinner with all the real checking done by gallery elements?

Everlag commented 8 years ago

This is still a problem of fully loaded galleries but doesn't interrupt scrolling due to the new checking in #22.

If people complain about the massive cards at the bottom, I can reopen this.

Everlag commented 8 years ago

Turns out the fix for /set was trivial b0c6b9de82c2d47a31ecc40cd3f8bf892e646116