EverlastingHopeX / K-9-Modularization

Apache License 2.0
0 stars 0 forks source link

App crashes when a dynamic feature module installation fails #1

Open negarq opened 3 years ago

negarq commented 3 years ago

Hi,

I've been using this app, and when I try to choose the color picker, the app crashes and quits. Even restarting doesn't fix it, and I have to re-install the app to make it work again. The reason seems to be that every click on the color picker triggers the installation of a dynamic feature module, and the installation request fails, which isn't handled properly in the code, as mentioned here: https://developer.android.com/guide/playcore/play-feature-delivery#handle_request_errors

The same problem happens when I click on the "end-to-end encryption" option and the color picker options right after each other. The app crashes and requires re-installation. In this case, the installation request fails with the error code "ACTIVE SESSIONS LIMIT EXCEEDED" which isn't handled properly in the code.

Can you verify/fix that?

EverlastingHopeX commented 3 years ago

Thanks for reporting this issue. I don't have a google play developer account for a test now, I will get one and fix this in the near future.

negarq commented 3 years ago

Thanks for reporting this issue. I don't have a google play developer account for a test now, I will get one and fix this in the near future.

Thank you for your reply. Looking forward to hearing back from you.

EverlastingHopeX commented 3 years ago

Just a follow-up. I modified the package name so google play will allow me to release it, then I upload the app for an internal test. It will crash immediately after I click "next" on the welcome page. But it runs fine if I run this app with android studio instead of download it from google play. So now I'm figuring out how to debug when it is downloaded from google play, hopefully, there will be a fix.