Everlaw / nbts

NetBeans TypeScript editor plugin
282 stars 46 forks source link

Better and Easier Build #13

Closed geekdenz closed 8 years ago

geekdenz commented 8 years ago

At the moment, every time I check out the project, I have to manually add a couple of module dependencies. It would be good if that were not the case. It is a manual process that is annoying. I believe that just a few minor changes to the nbproject folder solves this issue.

I will make a pull request to fix this problem if it does.

jeffrey-easyesi commented 8 years ago

These modules don't exist in the current version of NetBeans (8.0.2); I get an error trying to build with your change:

/home/jeffrey/netbeans-8.0.2/harness/build.xml:174: No dependent module org.netbeans.modules.parsing.indexing
BUILD FAILED (total time: 0 seconds)
geekdenz commented 8 years ago

Oh. It's in NetBeans 8.1RC. Maybe you have earlier versions of the modules and could just redo the steps I did:

Should be straight-forward and only take 5 minutes of your time.

jeffrey-easyesi commented 8 years ago

It looks like 8.1 reorganized some modules, causing source-incompatible changes:

8.0.2 doesn't just have earlier versions of parsing.indexing and openide.util.ui; it doesn't have them at all, their classes being part of parsing.api and openide.util.

If I build the plugin on 8.0.2 (without the new module dependencies), the .nbm works on both 8.0.2 and 8.1RC2; it looks like NetBeans has a "Automatic Dependencies" system so that plugins declaring dependencies on only the old modules will still work. However, if I build the plugin on 8.1RC2 (with the new module dependencies added), the resulting .nbm will not install on 8.0.2:

screenshot from 2015-10-18 00 08 14

8.0.2 is the latest released version so the plugin needs to work on it, and due to 8.1's changes I think that means it has to be built on 8.0.2.

geekdenz commented 8 years ago

Couldn't you just do the steps I outlined in NB 8.0?

jeffrey-easyesi commented 8 years ago

But there are no module issues when the project is opened in 8.0.2. If I did somehow import 8.1's new modules, it wouldn't build in 8.0.2, and even if I could force it to build somehow, the .nbm wouldn't install in 8.0.2.

geekdenz commented 8 years ago

OK. Then this is a non-issue.