search

Everlaw / nbts

NetBeans TypeScript editor plugin
283 stars 46 forks source link

Support TS 2.9 refactorings: Rename file, move declaration to new file #137

Open Chris2011 opened 6 years ago

Chris2011 commented 6 years ago

Hey, please update NBTS to using TypeScript 2.9. Thx

Cheers

Chris

Chris2011 commented 6 years ago

Thx, but I thought, that the new editor features of the LSP from TS, are also implemented too. Like move code to new file, or rename file and change every references, etc.: https://blogs.msdn.microsoft.com/typescript/2018/05/31/announcing-typescript-2-9/#rename-move-file

Generate get and set, is working well.

Cheers

Chris

Chris2011 commented 6 years ago

I can create new tickets, if you want.

negora commented 4 years ago

Is there any plan to support this useful feature?

The last commit in this project was on July 2018, so I guess that the project is stalled. Am I right? If so, Is it because the new way of coding with TypeScript, in NetBeans IDE, is by using an external LSP, such as sourcegraph/javascript-typescript-langserver ?

Thank you for this fantastic plug-in.

Chris2011 commented 4 years ago

IMHO, this plugin has no business value anymore for the developers and/or they don't have time anymore. Anyway, the TypeScript support was implemented just few months ago. Atm the moment the TypeScript implementation lacks some features behind this plugin. If those will be fixed, there is no need for this plugin anymore here.

negora commented 4 years ago

@Chris2011 Some weeks ago I noticed an extra TypeScript plug-in in the list of installed plug-ins, in NetBeans 11.3. I guess you're referring to that one. I disabled Nbts for a moment, restarted and tried it. But there wasn't syntax highlighting, so I decided to turn Nbts on again. I'll try to track its evolution.

Do you know whether that new plug-in uses LSP? LSP is like the Holy Grail to me, but NetBeans IDE seems to lack documentation about how it's integrated. I've also noticed a new menu in Tools → Options → Editor → Language Servers.

Chris2011 commented 4 years ago

The extra plugin is the core module TypeScript which uses Textmate lexer for syntax highlighting and LSP for that so syntax highlighting should work. Yes new languages can be handled via the options Language Server. You need a name, an icon, a textmate file and the executable for the LS.Yes, LSP is used now more often.