Collapse PlayerUtils into EMIPlayer

Everneth / EMI

Everneth Management Interface - This is a all-inclusive tool to open up commands and access to players who help run the various teams for the Everneth Survival Multiplayer community

MIT License

3 stars 0 forks source link

Collapse PlayerUtils into EMIPlayer #97

Closed TptMike closed 2 years ago

TptMike commented 2 years ago

All PlayerUtils static methods are related to the EMIPlayer model class (PlayerUtils being legacy and EMIPlayer being implemented in later releases). Collapse the utils class into the model for future use and reference. This should be blocking future porting work as it will require refactoring code to use the new class for the static methods.

[x] Port EMIPlayer
[x] Collapse PlayerUtils into EMIPlayer and remove the file
[x] Refactor class for readability (add separating headers between sections)

Possible headers: EMIPlayer constructors, Getters/Setters, Static Utilities, Internal Methods

TptMike commented 2 years ago

During refactoring we've cut down on the amount of methods needed for retrieving a player record. New generics have been created getEmiPlayer() that are static in scope. Discord IDs are now being stored within the model as well. More refactoring is being done to EMIPlayer for cleaner code.

Causal effects of the refactor is leading to a high amount of further refactoring in the rest of the project to move away from PlayerUtils.getPlayerRow() to EMIPlayer.getEmiPlayer(). Once this is all completed, this will be ready for the PR.

TptMike commented 2 years ago

Last task completed and PR submitted. Time to pray