Turn on as many compiler warning flags as possible and clean up the code

Evernote / evernote-sdk-ios

Evernote SDK for iOS

Other

398 stars 130 forks source link

Turn on as many compiler warning flags as possible and clean up the code #66

Closed an0 closed 11 years ago

an0 commented 11 years ago

The SDK code triggers too many warnings. Please turn on -Wsign-compare, -Wstrict-selector-match and -Wunknown-pragmas so you can see the issues and hopefully clean up the code.

mustafa commented 11 years ago

There are 0 warnings in the code with the default XCode settings. We have also added additional compiler settings. There are 0 static analysis warnings as well. Compiler warning flags are highly opinionated. Please explain why you need the one's that you have mentioned. If you need them, please fee free to open a pull request and submit for review.

an0 commented 11 years ago

Because as an SDK, it is better to use as strict code standard as possible so that it can be easily integrated into any projects no matter how strict the coding rules they use.