search

EveryMundo / emDataStandards

EveryMundo's Data Standards
7 stars 20 forks source link

Restrict routeType to populate only with NONSTOP and CONNECTING #24

Closed BigDataKatha closed 5 years ago

BigDataKatha commented 6 years ago

https://everymundo.github.io/emDataStandards/documentation/build/#farenet3.0-farenet-3.0

Issue: Currently, the variable routeType can be populated with NONSTOP, CONNECTING, CODESHARE. https://github.com/EveryMundo/emDataStandards/blob/543463c46f5dd65a197f2e15f2d121526941395d/types/flight.schema.json#L309-L313 However, if we populate the variable with CODESHARE, the flight can still be NONSTOP or CONNECTING.

Solution:

Populate routeType only with NONSTOP OR CONNECTING, so that:

    "routeType": {
      "description": "NONSTOP, CONNECTING",
      "type": "string",
      "example": "NONSTOP"
    }

and leverage the existing boolean variable "isCodeshare" to indicate if the flight is a codeshare or not. https://github.com/EveryMundo/emDataStandards/blob/543463c46f5dd65a197f2e15f2d121526941395d/types/fareNet3.0.schema.json#L717-L721

@danielsan @neilgoldman @darielnoel @yartiles @EveryMundo/em-microservices-admin @howardem @anahiem @unoriginalbanter

BigDataKatha commented 5 years ago

@anaiscorinne and I agreed to move forward with this. I will be laying out the documents that need to be updated.

BigDataKatha commented 5 years ago

I updated: flight_base.schema.json