currencyCode and currencySymbol have the same values, remove the currencySymbol field and obtain correct values from Dict

[maddy-at-work]

Currently, currencyCode: Variable values - USD currencySymbol: Variable value - USD instead of $ For most airlines where currencySymbol cannot be captured using farenet, currencyCode is duplicated in that field. Instead of this redundancy if we can remove this field altogether and obtain symbols using the dictionary.

[BigDataKatha]

Table: farenet_001 Type: https://github.com/EveryMundo/emDataStandards/blob/master/types/offer.schema.json Issue: Remove currencySymbol property under priceSpecification attribute on the offer-level because the symbol usually cannot be captured from the IBE and is currently being populated with the currency Code.

"priceSpecification": {
      "description": "Price Specification",
      "type": "object",
      "properties": {
        "currencyCode": {
          "description": "The currency (in 3-letter ISO 4217 format) of the price.",
          "type": "string",
          "example": "USD"
        },
        "currencySymbol": {
          "description": "Currency symbol",
          "type": "string",
          "example": "$"
        }
      }
    },

@anahiem @unoriginalbanter @danielsan @neilgoldman @howardem @renecairo @AVivero @yartiles Please review the above and let us know if you are using the FareNet field currencySymbol or if we can go ahead to remove it. Thank you!

[annisuu]

Hi @BigDataKatha, PMM does not use the field from FareNet, we have been working with our own mapping data for our price formatting in DPI. I will just double check with Vincent when he's back next week in case he uses it for reporting or another internal tool.

[BigDataKatha]

Leaving a comment that it was confirmed that FareWire does not use that field.

[BigDataKatha]

@anahiem did you follow up with Vince on this issue?

[annisuu]

@BigDataKatha Sorry, it took so long to reply, Vincent does not use this in any of his projects.

[BigDataKatha]

According to Maylin, airlines can have in their settings "Display Currency Symbol" checked, so they need to keep the currencySymbol in the Sputnik MS output fields, so TRFX can use that data.