EveryVoiceTTS / EveryVoice

The EveryVoice TTS Toolkit - Text To Speech for your language
https://docs.everyvoice.ca
Other
22 stars 2 forks source link

[FastSpeech2] Error logging should have better formatting #288

Open roedoejet opened 10 months ago

roedoejet commented 10 months ago

As of https://github.com/roedoejet/FastSpeech2_lightning/pull/20, error messages were changed to print statements, but pending a longer discussion of whether to use print statements or logger.error, these should be more visible. We will have a conversation about this in the future, but for this to work, we need to implement the following:

joanise commented 10 months ago

Looking at our use of logger.error() throughout the code base, I noticed that synthesize_text_dataset.py has two errors, one if language is not found, another if speaker is not found, but then the code proceeds anyway. Is that OK, or should that not sys.exit(1) like other error instances we have?

joanise commented 10 months ago

I was thinking a function simply named error(msg), which could support printf style arguments (like logger.error does), defined somewhere that will eventually be part of everyvoice-core when we create it (for now, maybe everyvoice/config/logs.py?)

logs.py should define error() and logger I guess.

joanise commented 9 months ago

I suggest we make this a beta milestone.