EveryVoiceTTS / EveryVoice

The EveryVoice TTS Toolkit - Text To Speech for your language
https://docs.everyvoice.ca
Other
20 stars 2 forks source link

TextProcessingStep doesn't work for data in festival format #495

Closed wiitt closed 2 months ago

wiitt commented 3 months ago

In TextProcessingStep, there is an assumption that data is stored as a list in a state under the "filelist_data_list" key while its not true for the festival format. Festival text is read as dictionary, and text is stored in a state under the "filelist_data" key. So, performing any kind of text processing raises a KeyError.

joanise commented 3 months ago

Thanks for catching this! This bug reveals once more how our unit testing for festival is incomplete. I see you've started a fix in dev.vg/496-wizard-festival-config, any chance you can also add some unit testing to cover this code? I know the monkey_run_tour stuff is not coder friendly, so it's OK if you punt and ask me to do it, but if you're willing to give it a shot that would be great!

roedoejet commented 2 months ago

fixed in #518