search

EveryVoiceTTS / EveryVoice

The EveryVoice TTS Toolkit - Text To Speech for your language
https://docs.everyvoice.ca
Other
19 stars 2 forks source link

fix: dependabot says to update to torch=2.2.0 #521

Open SamuelLarkin opened 2 months ago

SamuelLarkin commented 2 months ago

PR Goal?

Fix warnings for dependabot:

  1. https://github.com/EveryVoiceTTS/EveryVoice/security/dependabot/2
  2. https://github.com/EveryVoiceTTS/EveryVoice/security/dependabot/3
  3. https://github.com/EveryVoiceTTS/EveryVoice/security/dependabot/4
  4. https://github.com/EveryVoiceTTS/EveryVoice/security/dependabot/5

Fixes?

  1. https://github.com/EveryVoiceTTS/EveryVoice/security/dependabot/2
  2. https://github.com/EveryVoiceTTS/EveryVoice/security/dependabot/3
  3. https://github.com/EveryVoiceTTS/EveryVoice/security/dependabot/4
  4. https://github.com/EveryVoiceTTS/EveryVoice/security/dependabot/5

Feedback sought?

Merge approval

Priority?

medium-high

Tests added?

None

How to test?

Create a new conda environment using ./make-everyvoice-env --name EveryVoice.test then run ./run_tests.py. The CI also should be testing this.

Confidence?

Good

Version change?

No

Related PRs?

None

semanticdiff-com[bot] commented 2 months ago

Review changes with SemanticDiff.

github-actions[bot] commented 2 months ago 
CLI load time: 0:00.23
Pull Request HEAD: 60eb1f3b75de2a0a2593cb25c6b66581567399dd
Imports that take more than 0.1 s:
import time: self [us] | cumulative | imported package
codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.48%. Comparing base (3830a83) to head (60eb1f3).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #521 +/- ## ======================================= Coverage 74.48% 74.48% ======================================= Files 45 45 Lines 3029 3029 Branches 491 491 ======================================= Hits 2256 2256 Misses 679 679 Partials 94 94 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

SamuelLarkin commented 2 months ago

Version bump, sure. I mostly afraid of not been able to run EV on some cluster if we are too bleeding edge (older cluster setup). May be we should each pull that PR and to more than just the unittests.

roedoejet commented 2 months ago

Version bump, sure. I mostly afraid of not been able to run EV on some cluster if we are too bleeding edge (older cluster setup). May be we should each pull that PR and to more than just the unittests.

Right yea - have you tried installing it on gpsc-c with this configuration? I expect it should be fine there, but maybe run into problems elsewhere. Are the dependabot warnings serious?