EveryVoiceTTS / EveryVoice

The EveryVoice TTS Toolkit - Text To Speech for your language
https://docs.everyvoice.ca
Other
19 stars 2 forks source link

Basic Objective evaluation #525

Closed roedoejet closed 4 weeks ago

roedoejet commented 1 month ago

PR Goal?

Allow EveryVoice to do some basic evaluation by running everyvoice evaluate on either a single wav or directory of wavs.

Fixes?

Feedback sought?

Try it out, is the API intuitive?

Priority?

medium

Tests added?

A unit test of the evaluation is included, other test ideas are welcome.

How to test?

run everyvoice evaluate --help and then follow the instructions on some audio that you have.

Confidence?

medium

Version change?

minor

Related PRs?

N/A

semanticdiff-com[bot] commented 1 month ago

Review changes with SemanticDiff.

Analyzed 3 of 5 files.

Overall, the semantic diff is 6% smaller than the GitHub diff.

Filename Status
:heavy_check_mark: everyvoice/cli.py Analyzed
:grey_question: everyvoice/evaluation.py Unsupported file format
:heavy_check_mark: everyvoice/run_tests.py 83.33% smaller
:heavy_check_mark: everyvoice/tests/test_cli.py Analyzed
:grey_question: everyvoice/tests/test_evaluation.py Unsupported file format
github-actions[bot] commented 1 month ago
CLI load time: 0:00.25
Pull Request HEAD: 8a9d73388efd10a817b3b1327fc0acf03dfb56a0
Imports that take more than 0.1 s:
import time: self [us] | cumulative | imported package
import time:       249 |     100583 | typer
codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 86.25000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 74.60%. Comparing base (4c8bf94) to head (8a9d733). Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
everyvoice/cli.py 86.66% 2 Missing and 4 partials :warning:
everyvoice/evaluation.py 85.71% 2 Missing and 3 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #525 +/- ## ========================================== + Coverage 74.31% 74.60% +0.29% ========================================== Files 45 46 +1 Lines 3048 3127 +79 Branches 495 511 +16 ========================================== + Hits 2265 2333 +68 - Misses 689 693 +4 - Partials 94 101 +7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

roedoejet commented 1 month ago

@wiitt brought up a good point - we should also print out the file basename or path when printing to evaluation.json so that we can determine which files received particular scores.

joanise commented 1 month ago

Just taking an overview look:

joanise commented 1 month ago

@roedoejet Sam and I figured out pre-commit CI, it's fixed now.