Make sure ffmpeg is installed, and show a clear message if not

joanise commented 1 month ago

PR Goal?

Make sure ffmpeg is installed, and error out for a clear message if not

two changes:

make-everyvoice-env now just always installs ffmpeg
everyvoice demo exits right away if ffmpeg is not found, since we know we'll crash when the user eventually clicks on synthesize

Fixes?

Fixed #527

Feedback sought?

general validation

Priority?

beta

Tests added?

no, because we don't have any CI for everyvoice demo at the moment.

How to test?

1) get yourself an environment where ffmpeg is not installed (which ffmpeg will return nothing) and run everyvoice demo fp.ckpt vocoder.ckpt and see it exit with clear instructions.

2) create a new environment with make-everyvoice-env and see that which ffmpeg is right in your conda env.

Confidence?

high

I tested this thoroughly, with ffmpeg not on my path, and with ffmpeg on my path but corrupted (and thus not runnable) and you get the error message each time, whereas with a good ffmpeg things proceed normally.

Version change?

no

Related PRs?

semanticdiff-com[bot] commented 1 month ago

Review changes with SemanticDiff.

Analyzed 1 of 2 files.

	Filename	Status
:grey_question:	make-everyvoice-env	Unsupported file format
:heavy_check_mark:	everyvoice/demo/app.py	Analyzed

github-actions[bot] commented 1 month ago

CLI load time: 0:00.25
Pull Request HEAD: 61abbd4a887650d5b4ef32d411441fb9edce61e7
Imports that take more than 0.1 s:
import time: self [us] | cumulative | imported package

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 74.23%. Comparing base (3830a83) to head (61abbd4). Report is 6 commits behind head on main.

Files with missing lines	Patch %	Lines
everyvoice/demo/app.py	0.00%	10 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #533 +/- ## ========================================== - Coverage 74.48% 74.23% -0.25% ========================================== Files 45 45 Lines 3029 3039 +10 Branches 491 491 ========================================== Hits 2256 2256 - Misses 679 689 +10 Partials 94 94 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

EveryVoiceTTS / EveryVoice