EveryVoiceTTS / EveryVoice

The EveryVoice TTS Toolkit - Text To Speech for your language
https://docs.everyvoice.ca
Other
21 stars 2 forks source link

Dev.ej/clarify text to spec #553

Closed joanise closed 1 month ago

joanise commented 2 months ago

PR Goal?

It always takes me too long to figure out which model I need to provide when the help says I need a text-to-spec model.

This PR clarifies that.

Fixes?

My lack of intuition for why "spec" and "features" are synonyms... I'm probably not the only one!

Priority?

low

Tests added?

n/a

How to test?

run

and see the model path description clarified

Confidence?

high, but there is one question mark: are all text-to-spec models feature prediction models? If not, and there are other kinds, I would write (e.g., feature prediction) instead of (i.e., feature prediction).

Version change?

no

Related PRs?

https://github.com/EveryVoiceTTS/FastSpeech2_lightning/pull/89

semanticdiff-com[bot] commented 2 months ago

Review changes with SemanticDiff.

Analyzed 2 of 2 files.

Filename Status
:heavy_check_mark: everyvoice/cli.py Analyzed
:heavy_check_mark: everyvoice/model/feature_prediction/FastSpeech2_lightning Analyzed
codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.64%. Comparing base (bbc883d) to head (d036358). Report is 10 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #553 +/- ## ======================================= Coverage 74.64% 74.64% ======================================= Files 46 46 Lines 3132 3132 Branches 510 510 ======================================= Hits 2338 2338 Misses 693 693 Partials 101 101 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 2 months ago
CLI load time: 0:00.23
Pull Request HEAD: e3562eb7202d280c7717f0c024dc5805915ec108
Imports that take more than 0.1 s:
import time: self [us] | cumulative | imported package
joanise commented 1 month ago

CI changes spliced out. CI will fail here until #557 is merged...