Closed joanise closed 1 month ago
Review changes with SemanticDiff.
Analyzed 2 of 2 files.
Filename | Status | |
---|---|---|
:heavy_check_mark: | everyvoice/cli.py | Analyzed |
:heavy_check_mark: | everyvoice/model/feature_prediction/FastSpeech2_lightning | Analyzed |
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 74.64%. Comparing base (
bbc883d
) to head (d036358
). Report is 10 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
CLI load time: 0:00.23
Pull Request HEAD: e3562eb7202d280c7717f0c024dc5805915ec108
Imports that take more than 0.1 s:
import time: self [us] | cumulative | imported package
CI changes spliced out. CI will fail here until #557 is merged...
PR Goal?
It always takes me too long to figure out which model I need to provide when the help says I need a text-to-spec model.
This PR clarifies that.
Fixes?
My lack of intuition for why "spec" and "features" are synonyms... I'm probably not the only one!
Priority?
low
Tests added?
n/a
How to test?
run
everyvoice demo -h
everyvoice synthesize from-text -h
and see the model path description clarified
Confidence?
high, but there is one question mark: are all text-to-spec models feature prediction models? If not, and there are other kinds, I would write
(e.g., feature prediction)
instead of(i.e., feature prediction)
.Version change?
no
Related PRs?
https://github.com/EveryVoiceTTS/FastSpeech2_lightning/pull/89