Closed joanise closed 2 months ago
Review changes with SemanticDiff.
Analyzed 3 of 3 files.
Overall, the semantic diff is 17% smaller than the GitHub diff.
Filename | Status | |
---|---|---|
:heavy_check_mark: | everyvoice/wizard/__init__.py | Analyzed |
:heavy_check_mark: | everyvoice/wizard/basic.py | 39.51% smaller |
:heavy_check_mark: | everyvoice/wizard/dataset.py | 26.81% smaller |
CLI load time: 0:00.24
Pull Request HEAD: 048d2c1a9a35101d34d1a4ab888a8b8c184fa488
Imports that take more than 0.1 s:
import time: self [us] | cumulative | imported package
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 74.64%. Comparing base (
eb460a2
) to head (048d2c1
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
PR Goal?
Support
~
and~username
in wizard. This is particularly important because questionary.path allows using tilde, but then our code didn't expand it so an anto-completed path would not work in the end.Fixes?
Fixes #539
Feedback sought?
approval
Priority?
high - milestone a4
Tests added?
yes
I had not, but this question make me go back and add them... 😄
How to test?
run the wizard and use ~ or ~username in path-related questions
Confidence?
high
Version change?
no
Related PRs?
no