Closed SamuelLarkin closed 1 month ago
Review changes with SemanticDiff.
Analyzed 7 of 7 files.
Overall, the semantic diff is 2% smaller than the GitHub diff.
Filename | Status | |
---|---|---|
:heavy_check_mark: | everyvoice/utils/__init__.py | Analyzed |
:heavy_check_mark: | everyvoice/tests/test_model.py | Analyzed |
:heavy_check_mark: | everyvoice/model/vocoder/HiFiGAN_iSTFT_lightning | Analyzed |
:heavy_check_mark: | everyvoice/model/feature_prediction/FastSpeech2_lightning | Analyzed |
:heavy_check_mark: | everyvoice/model/aligner/DeepForcedAligner | Analyzed |
:heavy_check_mark: | everyvoice/demo/app.py | Analyzed |
:heavy_check_mark: | everyvoice/base_cli/helpers.py | 27.63% smaller |
CLI load time: 0:00.32
Pull Request HEAD: 2a0cb095cc1d6f2dbeb9f374ec64912fdaa71185
Imports that take more than 0.1 s:
import time: self [us] | cumulative | imported package
import time: 261 | 101414 | typer
Attention: Patch coverage is 0%
with 6 lines
in your changes missing coverage. Please review.
Project coverage is 76.02%. Comparing base (
df1e234
) to head (2a0cb09
). Report is 3 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
everyvoice/base_cli/helpers.py | 0.00% | 6 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hum, I approved, but there's a problem with the submodule, I think it got rebased wrong, you'll need to rebase and redo the submodule update commit.
PR Goal?
Fix #263 by providing a friendlier message when the user provide the wrong checkpoint.
Fixes?
263
Feedback sought?
Merge approval
Priority?
high
Tests added?
Yes
How to test?
Confidence?
Good
Version change?
No
Related PRs?
https://github.com/EveryVoiceTTS/FastSpeech2_lightning/pull/90 https://github.com/EveryVoiceTTS/HiFiGAN_iSTFT_lightning/pull/35 https://github.com/EveryVoiceTTS/DeepForcedAligner/pull/24