search

Everyplay / serverbone

Backbone node.js additions to serve backbone collections/models over express
MIT License
5 stars 5 forks source link

fetch and other methods should not modify the passed options #15

Closed mzabaluev closed 9 years ago

mzabaluev commented 9 years ago

In Backbone, the convention on options parameters is that the options object is not modified by the callee. In Serverbone, the options are clobbered by, for example, fetch on the ACL models and collections. Furthermore, there are tests expecting that the options array is modified. The convention that options is an inout parameter in Serverbone methods may result in unnecessary surprise.

mzabaluev commented 9 years ago

I'd rather keep this open because fetch and other methods still modify the options. #16 only changed this in methods that had no tests to fail.