search

Everyplay / serverbone

Backbone node.js additions to serve backbone collections/models over express
MIT License
5 stars 5 forks source link

BaseModel: don't use isNew as 'no id' #27

Closed mzabaluev closed 9 years ago

mzabaluev commented 9 years ago

isNew method is currently implemented this way, so the implementation of url() uses it to check if the id attribute is present. The url needs just the id, so any overrides of isNew may corrupt the desired result.

coveralls commented 9 years ago

Coverage Status

Coverage remained the same at 89.48% when pulling 72cca54f46c1a500fbb487805b5b49388f6cfada on refactor/url-robustness into 50341cae9c1c39f851cb667a0a3aa36cb2d8e1e1 on master.