Closed duttaoindril closed 5 years ago
Hello @duttaoindril , Please refer to BUILD.md, where you can find clear instructions. In short:
npm install --target=3.1.8 --runtime=electron --disturl=https://atom.io/download/electron
in terminal.node ./node_modules/vsce/out/vsce package
to build .vsix.Please, let me know if you need further help. Currently I'm working on providing complete cross-platform support. I believe in a day or two it'll be ready.
Awesome, I'll wait on the cross-platform support 😁
Thank you! Sincere Regards, Oindril Dutta http://goog_799414691 odutta.me
On Thu, May 23, 2019 at 11:30 AM Evgeniy Peshkov notifications@github.com wrote:
Hello @duttaoindril https://github.com/duttaoindril , Please refer to BUILD.md https://github.com/EvgeniyPeshkov/syntax-highlighter/blob/master/BUILD.md, where you can find clear instructions. In short:
- Install Node.js from here https://nodejs.org/en/download/.
- Install node-gyp requirements for MacOS https://github.com/nodejs/node-gyp#on-macos.
- Open extension in VSCode and execute npm install --target=3.1.8 --runtime=electron --disturl=https://atom.io/download/electron in terminal.
- Execute node ./node_modules/vsce/out/vsce package to build .vsix.
Please, let me know if you need further help. Currently I'm working on providing complete cross-platform support. I believe in a day or two it'll be ready.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/EvgeniyPeshkov/syntax-highlighter/issues/1?email_source=notifications&email_token=ABF5K7RMUHDWEYJD64B5YSDPW3PDXA5CNFSM4HPIOSL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWDC6JA#issuecomment-495333156, or mute the thread https://github.com/notifications/unsubscribe-auth/ABF5K7SKSXMKHLW6YXT5Q3LPW3PDXANCNFSM4HPIOSLQ .
@duttaoindril , I'll notify you in this issue when it's ready.
@duttaoindril , It's ready. You can download extension from marketplace.
Or type code --install-extension evgeniypeshkov.syntax-highlighter
in terminal.
Please, let me know about your experience. I don't have any MacOS device, so your feedback will be very helpful.
Hello,
What specifically do you want me to test? So far opening JS files seems to look exactly the same.
Thank you, Sincere Regards, Oindril Dutta
Sent from my Pixel 3 XL.
On Fri, May 24, 2019, 05:46 Evgeniy Peshkov notifications@github.com wrote:
@duttaoindril https://github.com/duttaoindril , It's ready. You can download extension from marketplace https://marketplace.visualstudio.com/items?itemName=evgeniypeshkov.syntax-highlighter . Or type code --install-extension evgeniypeshkov.syntax-highlighter in terminal. Please, let me know about your experience. I don't have any MacOS device, so your feedback will be very helpful.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/EvgeniyPeshkov/syntax-highlighter/issues/1?email_source=notifications&email_token=ABF5K7VOV6FQQP36AA6QYQTPW7PRZA5CNFSM4HPIOSL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWFGW6I#issuecomment-495610745, or mute the thread https://github.com/notifications/unsubscribe-auth/ABF5K7QNNXDBT7HVUKPFLWTPW7PRZANCNFSM4HPIOSLQ .
@duttaoindril , this is strange, extension works for me under both Windows and Linux, should work in MacOS too. Just in case, please, make sure you have at least 0.2.0 version. Meanwhile, I'll try to use VM to test extension under MacOS. Thank you for patience.
Hi, I had to restart my computer to see changes.
Looks 😎!
On Fri, May 24, 2019 at 8:06 AM Evgeniy Peshkov notifications@github.com wrote:
@duttaoindril https://github.com/duttaoindril , this is strange, extension works for me under both Windows and Linux, should work in MacOS too. Just in case, please, make sure you have at least 0.2.0 version. Meanwhile, I'll try to use VM to test extension under MacOS. Thank you for patience.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/EvgeniyPeshkov/syntax-highlighter/issues/1?email_source=notifications&email_token=ABF5K7Q4VLQL2SEBIKLB2X3PW776DA5CNFSM4HPIOSL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWFVCKI#issuecomment-495669545, or mute the thread https://github.com/notifications/unsubscribe-auth/ABF5K7R5V2MFCZVT4YJYR4TPW776DANCNFSM4HPIOSLQ .
-- Oindril Dutta Odutta.com Sent by iPad.
So everything works? Right?
Yes, haha.
What would you like me to test?
Thank you! Sincere Regards, Oindril Dutta http://goog_799414691 odutta.me
On Fri, May 24, 2019 at 8:09 AM Evgeniy Peshkov notifications@github.com wrote:
So everything works? Right?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/EvgeniyPeshkov/syntax-highlighter/issues/1?email_source=notifications&email_token=ABF5K7W5ESAW46QPNUESQU3PXAAJZA5CNFSM4HPIOSL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWFVNHI#issuecomment-495670941, or mute the thread https://github.com/notifications/unsubscribe-auth/ABF5K7S5SYSBGOZGJYNIB53PXAAJZANCNFSM4HPIOSLQ .
@duttaoindril , I just wanted to be sure, that extension works under MacOS (=. Thank you very much for your help. I'll close the issue then. Please, don't hesitate to rate Syntax Highlighter in Marketplace, your feedback is very valuable.
Awesome! Thank you so much, and you're welcome.
Thank you! Sincere Regards, Oindril Dutta http://goog_799414691 odutta.me
On Fri, May 24, 2019 at 8:36 AM Evgeniy Peshkov notifications@github.com wrote:
@duttaoindril https://github.com/duttaoindril , I just wanted to be sure, that extension works under MacOS (=. Thank you very much for your help. I'll close the issue then. Please, don't hesitate to rate Syntax Highlighter in Marketplace https://marketplace.visualstudio.com/items?itemName=evgeniypeshkov.syntax-highlighter, your feedback is very valuable.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/EvgeniyPeshkov/syntax-highlighter/issues/1?email_source=notifications&email_token=ABF5K7T4AMENTBV6GI6EWELPXADODA5CNFSM4HPIOSL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWFXW5I#issuecomment-495680373, or mute the thread https://github.com/notifications/unsubscribe-auth/ABF5K7X62MPRS5L6XEEZLPDPXADODANCNFSM4HPIOSLQ .
Any notes?