[C/C++] Member access highlighting

EvgeniyPeshkov / syntax-highlighter

Syntax Highlighter extension for Visual Studio Code (VSCode). Based on Tree-sitter.

https://marketplace.visualstudio.com/items?itemName=evgeniypeshkov.syntax-highlighter

MIT License

210 stars 43 forks source link

[C/C++] Member access highlighting #13

Closed alekseyt closed 5 years ago

alekseyt commented 5 years ago

This is a question.

Is member access highlighting something tree-sitter can do? Like this:

Note that z, y, x and w are highlighted in blue.

Example code:

b_ptr->z->y.x->w = 12.5f - 11 + 10.0;

EvgeniyPeshkov commented 5 years ago

You mean highlight local variables and members differently? Right?

alekseyt commented 5 years ago

Simply putting yes, i mean parts after '->' and '.' that highlighted in blue on screenshot. This indicates that it's a member variable. Original object being accessed is colored differently indeed.

EvgeniyPeshkov commented 5 years ago

There are several reasons.

What if the most outer object b_ptr is in turn member. Then it's not obvious how to highlight it, like a member, or like a local variable. Being just syntax parser, tree-sitter cannot distinguish them.
Why highlight b_ptr differently? Maybe it's better to give preference to w, as the last property in the chain.
For example, for me it's more comfortable and simply enough to highlight all variables as variables and all functions as functions. I do not follow idea "more colors - better'.

alekseyt commented 5 years ago

OK, thanks, i'm closing this issue then.