search

EvgenyKarkan / EKAlgorithms

EKAlgorithms contains some well known CS algorithms & data structures.
MIT License
2.42k stars 362 forks source link

Finish find & delete method in EKBSTree Class #55

Closed evianzhow closed 10 years ago

evianzhow commented 10 years ago

Dirty and Quick, maybe someone can improve it :)

stanislaw commented 10 years ago

@AustinChou, could you please also add some unit tests to cover this EKBSTree functionality? Just follow the way the unit tests for other parts of EKAlgorithms are written.

EvgenyKarkan commented 10 years ago

Glad that data structures section is alive :)

stanislaw commented 10 years ago

@AustinChou, I've just created my Pull Request #56. See there, what I really mean when I say "Unit Tests" - it is not about just writing a demo in main.m, but more likely about writing some test scenarios that ensure that a piece of code being tested actually works.

EKAlgorithms needs more and more Unit Tests coverage so every of its algorithms ideally would not only be useful as demonstration stuff but also could be used in real production code. This what I contribute to EKAlgorithms and I suggest you to do it the same way :)

Of course, all this matters only if you have any free time to polish EKAlgorithms as I do.

@EvgenyKarkan, I really suggest you to write some contribution guide emphasizing a preference given to the pull requests which contain test coverage of a stuff they promote!

evianzhow commented 10 years ago

@stanislaw I have no idea about "Unit Tests", but I will hand on learning it. Thanks!