Open Lane opened 6 years ago
The ranking page is unusable when running locally, there are seconds of delay any time you go to scroll. When I view on the staging / beta links, there is still a noticeable delay, but it's usable.
Spent a bunch of time trying to fix this today but having a hard time pinpointing where the problem is. Some thing I've tried:
ViewEncapsulation.None
on the rankings components. Some articles / issues I was looking at suggests that using attribute selectors for styling (which angular does a lot) is bad for performance on IE: https://medium.com/@antipov.alexei/ie11-performance-bottleneck-de304569361dranking-ui
, ranking-list
, or ranking-panel
) is present on the page, but gets noticeably worse with each component on the page. ranking-ui
, ranking-list
, and ranking-panel
so they only render a static paragraph. Still scrolls slowly! ranking-ui
, ranking-list
, and ranking-panel
components that are specified in evictions.component.html
. Scrolls at an acceptable speedSo, it seems like the scrolling performance is somehow tied to passing data into child components. I can't see anything that'd be problematic by looking... so we'll probably need to dive into this a bit more.
Given scrolling works okay on non-dev environments and the potentially infinite amount of time to debug this, setting as a low priority post-launch task.
This is still not something worth resolving until after launch, but I've also noticed this in both Safari and Firefox. It's only in local development though, so still not a priority
Yeah, it's bad in development. I think building a service worker to handle data retrieval, filtering, sorting would help a lot.. and maybe breaking up CSVs based on area type?
That makes sense to me! Honestly breaking up the area types would probably go a long way on its own. I don't think it's too bad in production, so I'm hesitant to rock the boat, but splitting up the CSVs seems like low hanging fruit after launch
There is a noticeable delay when scrolling rankings on IE11.