search

Evidlo / passhole

A secure hole for your passwords (KeePass CLI)
GNU General Public License v3.0
199 stars 19 forks source link

Exit with code 1 on error #42

Closed ulken closed 3 years ago

ulken commented 3 years ago

I simply replaced all occurrences of sys.exit() with sys.exit(1). I went through all of them before committing and found it reasonable. All explicit exits (in contrast to when normal execution of the program is done) indicate something unexpected has happened.

I wasn't able to actually run the program. How do I do that? I tried running the main Python file but it complains about relative import of version in a non-package. Tried using -m and specifying the package/module name but never found the right combo.

Closes #41

Evidlo commented 3 years ago

pip should put both ph and passhole in your PATH. You should be able to execute those commands directly.

ulken commented 3 years ago

pip should put both ph and passhole in your PATH. You should be able to execute those commands directly.

Oh, wow. So it overwrites the bins installed from the registry? Interesting.

Evidlo commented 3 years ago

Oh, wow. So it overwrites the bins installed from the registry? Interesting.

You mean the system binaries in /usr/local? Yes its possible that pip can overwrite them with sudo. That's why its recommended to generally use --user when installing with pip or use a virtualenv.

ulken commented 3 years ago

Alright, cool. Thanks!