search

Evidlo / remarkable_mouse

use your reMarkable as a graphics tablet
GNU General Public License v3.0
514 stars 49 forks source link

Pressure sensing on Windows, dynamic monitor selection #90

Open aklevans opened 3 months ago

aklevans commented 3 months ago

Builds upon @DCS-87's implementation of pressure sensing on Windows.

Dynamically changes the monitor to output to based on mouse position. This is now on by default and is overridden when the --monitor or --region tags are used.

Additionally, the program can now be exited using Ctrl-C, which did not use to work. The only option was to close the console which made restarting a pain.

I think these changes are significant enough to be worth publishing a new version to PyPi!

Evidlo commented 1 day ago

Thanks for putting the work into this. I'd be happy to merge in support for pressure on Windows, but this needs to be cleaned up quite a bit.

  1. I'd much rather the argument be called --windows or something like that. --pen isn't very descriptive.
  2. pen.py is rather messy. There are lots of unused constants, inconsistent coding style (e.g. camelcase applyPen). This file needs a refactor.
  3. Remove the automonitor feature from the PR. We can talk about adding this behavior in an issue, but it's easier if this was removed for now.