search

Evie-Skinner18 / happy_hacktoberfest_19

A fun website built to celebrate open source collaboration. Go ahead and create something!
18 stars 114 forks source link

[Bug] Fix the broken layout of the webpage #127

Closed maniac-tech closed 5 years ago

maniac-tech commented 5 years ago

The current layout is broken with cards overlapping each other. Needs to be fixed.

maniac-tech commented 5 years ago

@Evie-Skinner18 I would like to pick this up

NitinNair89 commented 5 years ago

Thanks @maniac-tech I had already sent the PR to fix it 1 hour ago :slightly_smiling_face:

https://github.com/Evie-Skinner18/happy_hacktoberfest_19/pull/124

maniac-tech commented 5 years ago

I did see the PR which raised, along with the Contributor's file. But I don't understand why do we have cards on the webpage with z-index 2 containing placeholders?

NitinNair89 commented 5 years ago

I did see the PR which raised, along with the Contributor's file. But I don't understand why do we have cards on the webpage with z-index 2 containing placeholders?

I am not sure either. It was probably merged because it looked good, I have no idea :laughing:

We can simply move it to your contributors webpage.

maniac-tech commented 5 years ago

Let's keep it on hold till the Contributor's page goes live, and then we can start cleaning up the layout.

What are your views?

NitinNair89 commented 5 years ago

Let's keep it on hold till the Contributor's page goes live, and then we can start cleaning up the layout.

What are your views?

Agreed. @WorkInProgress-Development @Evie-Skinner18 Thoughts?

SARAN-thala commented 5 years ago

We need to fix this issue.

NitinNair89 commented 5 years ago

We need to fix this issue.

Yes. Waiting for @Evie-Skinner18 or @WorkInProgress-Development to review and merge the pull request

NitinNair89 commented 5 years ago

@maniac-tech - Can you fix the layout and send a PR? I can review and merge

maniac-tech commented 5 years ago

Yes, I'll take care of it.

maniac-tech commented 5 years ago

You can assign this to me @NitinNair89

NitinNair89 commented 5 years ago

You can assign this to me @NitinNair89

Done! :slightly_smiling_face:

maniac-tech commented 5 years ago

Can we have a Code Freeze till I have the layout corrected?

NitinNair89 commented 5 years ago

Can we have a Code Freeze till I have the layout corrected?

Yup, we won't merge any PRs until layout is fixed. But do pull the latest version before you start development.

maniac-tech commented 5 years ago

Yes @NitinNair89 👍