search

Evie-Skinner18 / happy_hacktoberfest_19

A fun website built to celebrate open source collaboration. Go ahead and create something!
18 stars 114 forks source link

Add Contributors List in about page #129

Closed SARAN-thala closed 4 years ago

SARAN-thala commented 4 years ago

Right now the contributors list stored in JSON file. we can’t get directly from github api they rate limit of 60req/hour.

This is will solve issue #128

NitinNair89 commented 4 years ago

Right now the contributors list stored in JSON file. we can’t get directly from github api they rate limit of 60req/hour.

This is will solve issue #128

We don't need GitHub API. You can use native JavaScript to read the JSON file and present the data from it.

maniac-tech commented 4 years ago

As @NitinNair89 mentioned, I have already created a JSON file and I'm reading it from JS and printing the data.

Maybe @SARAN-thala can build on top of that?

SARAN-thala commented 4 years ago

Yeah, I read data from the local JSON file only

SARAN-thala commented 4 years ago

This is how it looks

Screenshot 2019-10-02 at 6 20 56 PM
SARAN-thala commented 4 years ago

It closed #97 aswell