search

Evie-Skinner18 / happy_hacktoberfest_19

A fun website built to celebrate open source collaboration. Go ahead and create something!
18 stars 114 forks source link

Make a Hallowe'en page #189

Closed Evie-Skinner18 closed 4 years ago

Evie-Skinner18 commented 4 years ago

The Witching Hour is almost upon us! Do you celebrate Hallowe'en / el Dia de los Muertos / another seasonal festival that I don't know about? Let's share it with the world 🎃 💀 Cultural exchange!

Evie-Skinner18 commented 4 years ago

NB this is for first timers only ✌️

anth-dev commented 4 years ago

I would like to help with this.

Evie-Skinner18 commented 4 years ago

Go for it!

anth-dev commented 4 years ago

Page is completed and pull request has been submitted

ghost commented 4 years ago

I would like to help too, if there is something left

Evie-Skinner18 commented 4 years ago

@lemrkcz absolutely! First thing you can do is rebase your forked version of the project and add a link to the Hallowe'en page in the navbar. Currently we have @anth-dev 's Hallowe'en page but no way of navigating to it. Enjoy! :ghost:

ghost commented 4 years ago

Would really enjoy doing something for this, if there's still some tasks available! :)

ghost commented 4 years ago

@lemrkcz absolutely! First thing you can do is rebase your forked version of the project and add a link to the Hallowe'en page in the navbar. Currently we have @anth-dev 's Hallowe'en page but no way of navigating to it. Enjoy! 👻

@Evie-Skinner18 Should it be placed in the nav-bar or in the event-dropdown?

Evie-Skinner18 commented 4 years ago

@lemrkcz I don't mind at all, will have a look at your PR.

@eprendes yes definitely happy coding!

ghost commented 4 years ago

Okay, made a PR for my new page! Please feel free to let me know if I made mistakes. I'm only halfway in to my first HTML class so it's basic :)