search

Evie-Skinner18 / happy_hacktoberfest_19

A fun website built to celebrate open source collaboration. Go ahead and create something!
18 stars 114 forks source link

Countdown till Halloween #214

Closed Jarrod2112 closed 4 years ago

Evie-Skinner18 commented 4 years ago

Hi @Jarrod2112 , thanks so much for this wonderful contribution. Currently if I merge it, the users will have no way of seeing your creation! Please can you add a link in the navbar to your page so that people can access it, and resubmit? Cheers

Jarrod2112 commented 4 years ago

Afternoon, Thank you for the project opportunity. I have added the link to the index.html page. Tried pushing it to my branch. Thought I was successful, then checked repo branch and changes were not there. I have attached a screenshot of the updates and the git commands. Was wondering if you might have any advice as to what I did wrong. Any direction would be most appreciated. This will make 4 PR's for my first Hacktoberfest . Pretty excited

On Tue, Oct 22, 2019 at 11:59 AM Evie Skinner notifications@github.com wrote:

Hi @Jarrod2112 https://github.com/Jarrod2112 , thanks so much for this wonderful contribution. Currently if I merge it, the users will have no way of seeing your creation! Please can you add a link in the navbar to your page so that people can access it, and resubmit? Cheers

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Evie-Skinner18/happy_hacktoberfest_19/pull/214?email_source=notifications&email_token=AKR2FS5MPC4CWFQ34LLTZNDQP4WP7A5CNFSM4JCR3ZFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEB6OYWI#issuecomment-545057881, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKR2FS4JMFXQKWDKX32J56DQP4WP7ANCNFSM4JCR3ZFA .

Jarrod2112 commented 4 years ago

Have created link in index.html as well as a new countDown.html page.

On Tue, Oct 22, 2019 at 5:48 PM jarrod cabarubio jarrodcabarubio7@gmail.com wrote:

Afternoon, Thank you for the project opportunity. I have added the link to the index.html page. Tried pushing it to my branch. Thought I was successful, then checked repo branch and changes were not there. I have attached a screenshot of the updates and the git commands. Was wondering if you might have any advice as to what I did wrong. Any direction would be most appreciated. This will make 4 PR's for my first Hacktoberfest . Pretty excited

On Tue, Oct 22, 2019 at 11:59 AM Evie Skinner notifications@github.com wrote:

Hi @Jarrod2112 https://github.com/Jarrod2112 , thanks so much for this wonderful contribution. Currently if I merge it, the users will have no way of seeing your creation! Please can you add a link in the navbar to your page so that people can access it, and resubmit? Cheers

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Evie-Skinner18/happy_hacktoberfest_19/pull/214?email_source=notifications&email_token=AKR2FS5MPC4CWFQ34LLTZNDQP4WP7A5CNFSM4JCR3ZFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEB6OYWI#issuecomment-545057881, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKR2FS4JMFXQKWDKX32J56DQP4WP7ANCNFSM4JCR3ZFA .

Evie-Skinner18 commented 4 years ago

Thanks again and sorry for merging so late!