search

Evie-Skinner18 / happy_hacktoberfest_19

A fun website built to celebrate open source collaboration. Go ahead and create something!
18 stars 114 forks source link

Secret Floof Portal to Happiness Added #219

Open Rendamage opened 4 years ago

Rendamage commented 4 years ago

Need to add links to the events drop down but currently can view with a hard link.

Evie-Skinner18 commented 4 years ago

Hiya @Rendamage , thanks for this. This PR is deffo an improvement! Can you change your image src links so they're not pointing at your C drive? There's no need to include the C drive part in the link, if your image is residing in the images folder, you can just point to that! :zap: :smiley: I recommend that you rebase before you make your changes aswell just in case you've missed anything.

Rendamage commented 4 years ago

Hi Evie,

Thanks for the advice. Will do.

All the best,

Renos

Get Outlook for Androidhttps://aka.ms/ghei36

From: Evie Skinner notifications@github.com Sent: Tuesday, October 22, 2019 6:29:34 PM To: Evie-Skinner18/happy_hacktoberfest_19 happy_hacktoberfest_19@noreply.github.com Cc: Rendamage renos18@hotmail.com; Mention mention@noreply.github.com Subject: Re: [Evie-Skinner18/happy_hacktoberfest_19] Secret Floof Portal to Happiness Added (#219)

Hiya @Rendamagehttps://github.com/Rendamage , thanks for this. This PR is deffo an improvement! Can you change your image src links so they're not pointing at your C drive? There's no need to include the C drive part in the link, if your image is residing in the images folder, you can just point to that! ⚡️ 😃 I recommend that you rebase before you make your changes aswell just in case you've missed anything.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/Evie-Skinner18/happy_hacktoberfest_19/pull/219?email_source=notifications&email_token=ANKBVTOI6UXP6DOJ46BVK5LQP4Z75A5CNFSM4JC7CV5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEB6RVOQ#issuecomment-545069754, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ANKBVTLUQDI5CZNNUUIWS63QP4Z75ANCNFSM4JC7CV5A.

WorkInProgress-Development commented 4 years ago

@Rendamage, would you like to submit a fixed and rebased pull request, or would you like me to do it?

Rendamage commented 4 years ago

@Rendamage, would you like to submit a fixed and rebased pull request, or would you like me to do it?

Hi Isaac, Could you fix this for me. I am not sure I would be able to do it without causing another merge conflict. A good lesson for me at least to remember to submit my code often and to use ../ for my images.