search

EvilBeaver / OneScript

Исполняющая среда скриптов на языке 1С
http://oscript.io
Mozilla Public License 2.0
480 stars 107 forks source link

closes #1451 #1453

Closed akpaevj closed 1 month ago

akpaevj commented 1 month ago

Summary by CodeRabbit

coderabbitai[bot] commented 1 month ago

Walkthrough

The changes involve an update to the RuntimeScopes class constructor, specifically in how the _outerScopes field is initialized. The previous implementation directly assigned the outerScopes parameter to _outerScopes, while the new implementation uses LINQ's Select method to create a new list of AttachedContext instances. This ensures that _outerScopes contains distinct instances rather than references to the original objects.

Changes

File Change Summary
src/ScriptEngine/Machine/RuntimeScopes.cs Updated _outerScopes initialization to use LINQ's Select for creating distinct AttachedContext instances.

Poem

In the code where rabbits play,
Distinct instances hop and sway.
With LINQ's magic, they now gleam,
A list of contexts, like a dream.
Hooray for changes, bright and new,
A joyful leap, we bid adieu! 🐇✨

📜 Recent review details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
📥 Commits Files that changed from the base of the PR and between e09146395a07e80b39044aaeab5edc7e0a35812d and 3d6d6d61c695357eeba4e08a7ec529c5b0db8c45.
📒 Files selected for processing (1) * src/ScriptEngine/Machine/RuntimeScopes.cs (2 hunks)
🔇 Additional comments (2)
src/ScriptEngine/Machine/RuntimeScopes.cs (2)
`11-11`: **LGTM: Added necessary using statement** The addition of `using System.Linq;` is appropriate as it's required for the LINQ operations used in the constructor. --- `28-28`: **Approved, but clarification needed on necessity and performance** The change to create new `AttachedContext` instances ensures that `_outerScopes` contains distinct objects rather than references to the original ones. This could prevent unintended modifications to the original `outerScopes` objects. However, I have a few questions: 1. Could you clarify why this change was necessary? Are there specific scenarios where modifying the original `outerScopes` objects caused issues? 2. Have you considered the potential performance impact of this change, especially for large `outerScopes` lists? To assess the usage and potential impact, let's analyze the codebase:
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
Mr-Rm commented 1 month ago

(не успел немного) Проблема устраняется, но не в том месте, где возникла. Достаточно в LibraryLoader.AddModule() после строки https://github.com/EvilBeaver/OneScript/blob/48446293578ca25910477111e507a539be66c1ab/src/ScriptEngine.HostedScript/LibraryLoader.cs#L115 Выполнить повторный Attach для MachineInstance.Current._globalContexts (точнее, для одного _globalContexts[0])

Mr-Rm commented 1 month ago

! Начал падать tests\eval.os: ТестДолжен_ПроверитьРекурсивныйВызовВыполнить ТестДолжен_ПроверитьВызовыВыполнитьСПопытками

EvilBeaver commented 1 month ago

! Начал падать tests\eval.os: ТестДолжен_ПроверитьРекурсивныйВызовВыполнить ТестДолжен_ПроверитьВызовыВыполнитьСПопытками

Забрал себе