Modernize and automate maintenance

Bluebugs commented 7 months ago

This should help address #14. This PR add

a GitHub Action that ensure that all GitHub Actions kind of look ok (This help a lot when using act locally).
a GitHub Action that ensure that a change from a PR will generate a working Docker image. It does for that build the image, start it with docker-compose, wait for RouterOS to have properly started and then check for the existence of a REST API end point. The last part only work for recent image and CI would not pass for older image.
a GitHub Action that for each push to master the image is working and only if it is, will it automatically push a tag that match RouterOS release. This action has extended access right and can write to git.
a GitHub Action that on new tag being pushed, an image is build and pushed to docker hub. This require the addition of secrets to the project: DOCKERHUB_USERNAME and DOCKERHUB_TOKEN. Git tag that are set on head of master should lead to the upload of two docker tag (latest and git tag).
a GitHub Action that will run once a day and check if there is a more recent image than the one served by this Git repository. If there is, it will automatically create a new PR. It will likely fail if a previously generated PR has not been taken care of.

Finally this also turn on dependabot to automate more of the maintenance process of this repository. Manual PR review are still required for anything to land in master at the moment, but additional github actions could be written to automatically review and approve dependabot and new routeros PR, but before doing so, it would be important to turn on branch protection and enforce that at least one approval is required along with the CI step passing.

I think this would make 99% of the maintenance work on this repository done. Of course is MikroTik update their website or change their file distribution method, this would break and that would require manual intervention. Otherwise everything else should be automated.

I have also added support for KVM to make the VM execution faster and modified docker-compose accordingly.

I understand I should have split this PR in multiple one (especially the part that modernize the Dockerfile), but here we are. If you would prefer it to be split, I can work toward that.

EvilFreelancer commented 7 months ago

Hi! Wow, cool PR!

Can you please rollback docker-compose.dist.yml? I've added this file for the reason, because my local docker-compose.yml a slightly different from dist, and i guess not only mine.

PS. Don't forget about fix in .gitignore

Bluebugs commented 7 months ago

Hi! Wow, cool PR!

Can you please rollback docker-compose.dist.yml? I've added this file for the reason, because my local docker-compose.yml a slightly different from dist, and i guess not only mine.

PS. Don't forget about fix in .gitignore

Ah, yeah, I was wondering why it had a weird naming. Will update my PR. Do you think there is any possibility to get to add the feature you are using to the repository docker-compose file?

Bluebugs commented 7 months ago

Done, let me know if there is anything necessary.

EvilFreelancer commented 7 months ago

Do you think there is any possibility to get to add the feature you are using to the repository docker-compose file?

I don't think my couple demo applications should be in docker-compose config :)

(btw, dist mean distributable)

EvilFreelancer commented 7 months ago

Thanks a lot for your help! Fixes merged to master, finally this project looks as it should.

EvilFreelancer / docker-routeros

Modernize and automate maintenance #20