Evizero / Augmentor.jl

A fast image augmentation library in Julia for machine learning.
https://evizero.github.io/Augmentor.jl/
Other
137 stars 48 forks source link

CI fails #77

Closed matsueushi closed 3 years ago

matsueushi commented 3 years ago

Hello,

Currently CI is falling, it seems it was caused by the ImageTransformations v0.8.8 release. All tests have passed when I downgraded it to v0.8.7. I guess the commit https://github.com/JuliaImages/ImageTransformations.jl/commit/a4f219020ad142c5a5bcdb03486e092fd8d9e02b has changed the result of invwarpedview.

julia> square = [0.1 0.2 0.3; 0.4 0.5 0.6; 0.7 0.6 0.9]
julia> x = Augmentor.prepareaffine(square)
julia> m = Augmentor.toaffinemap(Rotate90(), square)

With ImageTransformations v0.8.7:

julia> Augmentor.invwarpedview(x, m)
3×3 InvWarpedView(extrapolate(interpolate(::Array{Float64,2}, BSpline(Interpolations.Linear())), Flat()), AffineMap([6.123233995736766e-17 -1.0; 1.0 6.123233995736766e-17], [4.0, 0.0])) with eltype Float64 with indices 1:3×1:3:
0.3 0.6 0.9
0.2 0.5 0.6
0.1 0.4 0.7

With ImageTransformations v0.8.8:

julia> Augmentor.invwarpedview(x, m)
4×4 InvWarpedView(extrapolate(interpolate(::Array{Float64,2}, BSpline(Interpolations.Linear())), Flat()), AffineMap([6.123233995736766e-17 -1.0; 1.0 6.123233995736766e-17], [4.0, 0.0])) with eltype Float64 with indices 1:4×1:4:
 0.3  0.6  0.9  0.9
 0.2  0.5  0.6  0.6
 0.1  0.4  0.7  0.7
 0.1  0.4  0.7  0.7
johnnychen94 commented 3 years ago

Yeah, the result looks really wrong here. I'm not sure if I have the time to investigate this, would you help figure out what should be fixed here?

matsueushi commented 3 years ago

Okay, I'll take a look.

matsueushi commented 3 years ago

I made a PR related to this issue on ImageTransformations.jl