EvoEsports / EvoSC-sharp

Next generation server controller for Trackmania written in C# using .NET 8.
https://evosc.io
GNU General Public License v3.0
21 stars 13 forks source link

Implement Fastest CP module #122

Closed kdankert closed 1 year ago

kdankert commented 1 year ago

Started to work a bit on this as an introduction to this project. Already worked a bit with the old version written in PHP and would like to help in this rewrite.

I based this branch on the manialink branch, as I think, those features will be needed for the widget itself, though as far as I figured out the template engine is not quite ready yet.

Tests are still missing, but I couldn't figure out the guidelines for tests inside modules, as no module has tests so far.

In addition to that I still need to verify, that the state of the service is actually thread-safe, as events are most likely to be handled on multiple threads or am I mistaken.

I thought it would make sense to create a draft pull request though, to let you know that this module is being worked on and to get some early feedback.

Closes #27.

snixtho commented 1 year ago

Hwy, thanks for helping out! If you'd like, I can add you to the development channel in discord where we are discussing and collaborating on the development of EvoSC#. I think you made a ticket to help out at some point, but was never added to the channel? I can help you get sorted out if you contact me on discord: snixtho#9039

kdankert commented 1 year ago

This PR requires #128 to be merged before (target branch needs to be adjusted after). The last commit splitting the manialink manager interface can either be done in #122 or #128. (https://github.com/EvoTM/EvoSC-sharp/pull/128#discussion_r1161096922)

kdankert commented 1 year ago

Saw that, but couldn't figure out yet, what the problem is. First guess was, that this might be a caching issue, but I'll investigate further.

Figured out what the problem was. In order to use a local version of the template engine external tools like nulink have to be used.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication