Closed snixtho closed 1 year ago
Looks fine for me. We should definitely find a better way to mock contexts inside controllers. Also it would be great if test coverage could be improved. We should also integration test migrations to ensure they are working together (unit tests do not cover cases that might appear).
I agree, the tests in this PR are mostly only for what was actually added. There are a bunch of services and things in the core that needs tests, which we should create soon. I could make some issues on that.
Kudos, SonarCloud Quality Gate passed!
All current modules have their UI strings replaced with the localization system (hence the amount of files changed).
All localization and translations are managed here: https://crowdin.com/project/evosc-sharp