search

EvoEsports / EvoSC-sharp

A Trackmania Server Controller written in C# using .NET 8
https://evosc.io
GNU General Public License v3.0
20 stars 13 forks source link

Bad dependency in SpectatorTargetInfo ManiaTemplate #227

Open snixtho opened 8 months ago

snixtho commented 8 months ago

In the SpectatorTargetInfoModule the SpectatorTargetInfo template depends on Scoreboard.Components.PlayerRow.ClubTag from the scoreboard module.

First of all, it is not defined in the info.toml file that the SpectatorTargetInfoModule module depends on the Scoreboard module, and it will throw an exception if the scoreboard module is not loaded.

Second, I am not sure why a "club tag" component is part of the scoreboard module, and other modules will have to depend on the scoreboard module for this. Seems like an odd design decision. It would probably better to have such a component in the core instead.