search

EvoEsports / EvoSC-sharp

A Trackmania Server Controller written in C# using .NET 8
https://evosc.io
GNU General Public License v3.0
20 stars 13 forks source link

Mocking Migration to NSubstitute #241

Closed kdankert closed 1 month ago

kdankert commented 4 months ago

Fixes #190

sonarcloud[bot] commented 4 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

snixtho commented 4 months ago

Thing is, I'm not sure if we really need to do this anymore because moq reverted the changes after backlash.

kdankert commented 4 months ago

Couldn't really figure out if they only deployed a temporary fix due to incompatibilties on Mac machines or if they actually tweaked SponsorLink to be gdpr compliant. I had lots of the changes locally already and decided to to push them anyways, so that we could decide whether to incorporate them or not, basicly deciding which mocking framework to use. Personally, I would still prefer moq due to their explicit wrapper objects and the reason that NSubstitute automatically defines nested mocks, which produced some unexpected behavior.