EvoEsports / EvoSC-sharp

Next generation server controller for Trackmania written in C# using modern .NET
https://evosc.io
GNU General Public License v3.0
20 stars 13 forks source link

Fix missing Moq dep in TeamChat tests #299

Closed flaeri closed 1 month ago

flaeri commented 1 month ago

Adding Moq to the TeamChatModule resolves the issue I had on windows where I could not manage to get dotnet to resolve the and install the dependency.

Previously, if I ran dotnet list package inside of tests\Modules\TeamChatModule.Tests , Moq would be missing. With this change, it is now present:

Project 'TeamChatModule.Tests' has the following package references
   [net8.0]:
   Top-level Package                Requested   Resolved
   > coverlet.collector             6.0.0       6.0.0
   > Microsoft.NET.Test.Sdk         17.6.0      17.6.0
   > Moq                            4.20.70     4.20.70
   > xunit                          2.4.2       2.4.2
   > xunit.runner.visualstudio      2.4.5       2.4.5

The Moq specific build error I got on windows is also gone.

Build FAILED.

C:\repos\EvoSC-sharp\tests\Modules\TeamChatModule.Tests\Middlewares\TeamChatMiddlewareTests.cs(9,7): error CS0246: The type or namespace name 'Moq' could not be found (are you missing a using directive or an
assembly reference?) [C:\repos\EvoSC-sharp\tests\Modules\TeamChatModule.Tests\TeamChatModule.Tests.csproj]

I have not increased the versions in EvoSC.csproj or the README.md, as it did not make sense to me to do, nor did I find any version numbers to bump that made sense to bump.

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud