search

EvokeNet / humhub

A global network of social innovators
http://evokenet.org
5 stars 3 forks source link

Include explanation in "oops something's wrong" alerts #473

Closed nathanverrill closed 7 years ago

nathanverrill commented 7 years ago

If there is an error and the "oops, something's wrong" message is displayed to the user, include text about the issue, such as "comment required" or "tag required"

Guihrmsfo commented 7 years ago

It's not an issue, it's an error message when the cause is unknown. There are customized messages for such cases (i.g. comment required). You can close this issue since #472 covers the situation. I can change the text for something more appropriate if desirable.

nathanverrill commented 7 years ago

How is there something where the cause is unknown?

nathanverrill commented 7 years ago

Unless it's a really really far out edge case that fails the checks. Seems this is a simple form that should be easy to validate. I would put text in that says "Use the message box below to let us know what you were attempting to do and we will resolve it."

Guihrmsfo commented 7 years ago

In the code, when we try to save the review there are some cases we know why the review wouldn't be saved, like when the comment has not enough characters. If it doesn't match any of the known issues, this message is displayed.

nathanverrill commented 7 years ago

I would put #character check in the frontend so it is a faster check for the user