Closed japilo closed 1 year ago
@japilo It looks like your branch is out of sync with the base (i.e. dev
). See this article on how to fix that:
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/keeping-your-pull-request-in-sync-with-the-base-branch
Once you have done that, there should be no conflicts left, and it should then be easier to understand what is going on as only your changes will be flagged.
Attention: 2 lines
in your changes are missing coverage. Please review.
Comparison is base (
c7ee981
) 90.35% compared to head (b321265
) 90.21%.:exclamation: Current head b321265 differs from pull request most recent head 5a1e058. Consider uploading reports for the commit 5a1e058 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Two bug fixes here.
One bug that was causing major issues for me personally was that
sample_pseudoabs_time
threw errors when I used aterra::SpatRaster
input for theraster
argument. I realized that the function basically required theraster
argument to be aregion_series
object frompastclim
. I fixed the function so that it will accept eitherterra::SpatRaster
orterra::SpatRasterDataset
input, and changed the documentation accordingly.Second minor bug was that there was a
time
function insample_pseudoabs
that was not defined (bothterra
andstats
have atime
function.) I surmised that it was meant to beterra::time
and changed it.There are a bunch of problems in the vignettes right now that I don't feel qualified to fix, which means this branch doesn't pass standard checks, but if I run
devtools::check(vignettes = F)
then everything checks out fine.