search

Evoluty / google-maps-apis-php-client

This is a PHP client for Google Maps APIs
MIT License
0 stars 0 forks source link

Feature/sanitize #2

Closed juherr closed 5 years ago

codecov[bot] commented 5 years ago

Codecov Report

Merging #2 into master will increase coverage by 30.26%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #2       +/-   ##
===========================================
+ Coverage     69.73%   100%   +30.26%     
- Complexity       31     33        +2     
===========================================
  Files             6      6               
  Lines            76     73        -3     
===========================================
+ Hits             53     73       +20     
+ Misses           23      0       -23
Impacted Files Coverage Δ Complexity Δ
src/TimeZone/TimeZoneResponse.php 100% <ø> (ø) 9 <0> (?)
src/TimeZone/TimeZoneLocation.php 100% <ø> (ø) 2 <0> (?)
src/GoogleMapsResponse.php 100% <ø> (ø) 5 <0> (ø) :arrow_down:
src/GoogleMapsRequest.php 100% <100%> (ø) 6 <5> (+2) :arrow_up:
src/TimeZone/TimeZoneRequest.php 100% <100%> (ø) 5 <2> (?)
src/GoogleMapsClient.php 100% <100%> (+100%) 6 <1> (-1) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c1a649a...4fb4688. Read the comment docs.

Evoluty commented 5 years ago

Thanks for the changes. I totally agree with them. Can you add a newline at the end of the .gitignore file ? I think we need to fix the readme.md that I just added to be consistant with the new classes name "TimeZone" this could be included in the PR :) Nothing else to say this can be merged asap. Great one 👍

Evoluty commented 5 years ago

I think we need to add a new tag also for packagist :)

juherr commented 5 years ago

Done!

You're the owner, you merge! :)