Fix typo in Qwen-VL that was causing "reference before assignment"

EvolvingLMMs-Lab / lmms-eval

Accelerating the development of large multimodal models (LMMs) with lmms-eval

https://lmms-lab.github.io/

Other

1.03k stars 53 forks source link

Fix typo in Qwen-VL that was causing "reference before assignment" #61

Closed tupini07 closed 2 months ago

tupini07 commented 2 months ago

Hi! This PR fixes an issue in the Qwen-VL generate_until method that was caused by a typo (contexts[i] was being referenced as context[i]; singular). I also added an if statement that converts contexts to a list so we can use item assignment with the indexing operator. Finally, made a minor refactor to make the construction of the query more readable.

kcz358 commented 2 months ago

Hi @tupini07 , thank you for your contribution.

I think we also met the same issue when running inference with qwen. We solved it in a similar way but I think yours are better. @Luodian